Re: gEDA-dev: [PATCH] gschem: recent files support

[Peter TB Brett <peter-at-NOSPAMpeter-b_dot_co_dot_uk>]

On Monday 23 April 2007 22:43:11 Ivan Stankovic wrote:
> On Mon, Apr 23, 2007 at 08:04:27AM -0400, Ales Hvezda wrote:
> > [snip]
> >
> > >> 2. Use a different mechanism (good solution).
> > >
> > >I'm aware of this, but Ales suggested I use glib's keyfile mechanism.
> > >Personally, I don't think many people use glib (or gtk) 2.4 these
> > >days.
> >
> > 	I would prefer to push forward.  Please use the glib keyfile
> > mechanism and simply disable this new feature for a gtk+ less than 2.6.x.
> > That is, you can use gtk+ >= 2.6.x features as long as the code still
> > works with gtk+ 2.4.x (with maybe some disabled functionality).  At some
> > point I'm going to drop the gtk+ 2.4.x requirement, especially since
> > debian etch is now using 2.8.x.
>
> Here's a new patch. The recent files support should only be enabled
> if glib >= 2.6 is present. Please test, especially if you have an
> older glib version.

1. GLIB_CHECK_VERSION(2,6,0) to check the version rather than using 
GLIB_MINOR_VERSION?

2. I like the way you've disabled the features with a minimum number of 
#ifdefs.

3. Rather than adding an extra substitution to system-gschemrc.in (and an 
extra variable in configuration mechanism), why not delete the menu item in 
x_menu_attach_recent_files_submenu() if GLIB < 2.6?

4. There should probably be comment about the magicness of that menu entry in 
the Scheme file.

Cheers,

Peter

-- 
Fisher Society committee                    http://tinyurl.com/o39w2
CUSBC novices, match and league secretary   http://tinyurl.com/mwrc9
CU Spaceflight                              http://tinyurl.com/ognu2

v3sw6YChw7$ln3pr6$ck3ma8u7+Lw3+2m0l7Ci6e4+8t4Gb8en6g6Pa2Xs5Mr4p4
  hackerkey.com                                  peter-b.co.uk

PGP signature

_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev