Re: gEDA-dev: Ivan's gattrib patches

[Peter Clifton <pcjc2-at-NOSPAMcam_dot_ac_dot_uk>]

On Wed, 2007-08-01 at 15:19 -0400, Stuart Brorson wrote:
> Please go ahead and push them.  They worked fine for me.

The patch:

gattrib: remove unused code from x_gtksheet.c

Now leaves us with a compile warning:

x_gtksheet.c:349: warning: ‘set_cell’ defined but not used

(Previously it was unused, but not a static function - so the compiler
didn't know).

It also appears to remove some (but not all - set_cell appears to be one
case) of the code necessary to have a GtkEntry above the attributes
sheet for editing. I'm not a fan of leaving old code about, but there is
a comment which remains:


/*  Note that the entry cell is the text entry field at the top of the
 *  sheet's working area (like in MS E*cel).   I have removed this from
 *  gattrib, but leave the code in just in case I want to put it back.  */


Stuart:

Do you want this code in / out? If out, we can remove a lot more code.
If in, we can't apply this patch - at least not in its entirety.


Regards,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev