gEDA-dev: Gattrib crash with no pin number

[Peter Clifton <pcjc2-at-NOSPAMcam_dot_ac_dot_uk>]

Hi,

I get the following crash opening gattrib with one of my schematics.
Unfortunately I can't post it, however if necessary I'll distill a test
case.

I think the cause may be pretty obvious though:

gEDA/gattrib version 1.1.2.20070818
gEDA/gattrib comes with ABSOLUTELY NO WARRANTY; see COPYING for more details.
This is free software, and you are welcome to redistribute it under certain
conditions; please see the COPYING file for more details.

In s_sheet_data_add_master_pin_list_items, found component pin with no pinnumber.
In s_sheet_data_add_master_pin_list_items, found component pin with no pinnumber.
In s_sheet_data_add_master_pin_list_items, found component pin with no pinnumber.
In s_sheet_data_add_master_pin_list_items, found component pin with no pinnumber.

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1208759840 (LWP 21358)]
s_table_add_toplevel_pin_items_to_pin_table (start_obj=0x818fa60) at s_table.c:500
500                       ((sheet_head->pin_table)[row][col]).row = row;
(gdb) bt
#0  s_table_add_toplevel_pin_items_to_pin_table (start_obj=0x818fa60) at s_table.c:500
#1  0x0806e323 in x_fileselect_load_files (filenames=0x814f2a0) at x_fileselect.c:253
#2  0x08071d9d in gattrib_main (closure=0x0, argc=2, argv=0xbfbaaa94) at gattrib.c:212
#3  0x47a8b7d4 in scm_boot_guile (argc=2, argv=0xbfbaaa94, main_func=0x8071c00 <gattrib_main>, closure=0x0) at init.c:635
#4  0x08071bda in main (argc=2, argv=0xbfbaaa94) at gattrib.c:248
(gdb) print row
$1 = -1
(gdb) print col
$2 = 0

It seems:
row = s_table_get_index(sheet_head->master_comp_list_head, temp_uref);

is never tested for failure.

s_table_get_index(...) returns -1 if the temp_uref isn't found in the
component list.

What I'm not sure about - why the component wasn't found. I'm being lazy
and posting here rather than digging into it, as I figure Stuart may
know the answer quicker.

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev