gEDA-dev: Bug fix for obscure crash copying attributes

[Peter Clifton <pcjc2-at-NOSPAMcam_dot_ac_dot_uk>]

Hi Ales,

You might want to cherry-pick commit
#96495b7a87701b2ea8d7eb6b4da206d6c169a85c

for the stable branch.

    Fix memory corruption and possible segfault copying attributes
    
    If an object (but not all its attributes) was selected and copied, dangling
    pointers were left in the un-copied attributes. A subsequent copy operation
    containing those missed attributes would attempt to reattach them to the
    copy of their parent. If this had been deleted in the mean time, memory
    corruption and a possible segfault would occur.
    
    Consolidates the duplicated code which sets the ATTRIB property "copied_to"
    into a helper function, o_attrib_list_copied_to(). This is also used to
    clean up after copy operations.


>From the steps required to trigger, it is just possible that this was
the unreproducible crash Peter B saw some back whilst copying components
about.

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev