[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gEDA-dev: New slotting mechanism
On Nov 28, 2007 2:30 PM, Peter TB Brett <peter@peter-b.co.uk> wrote:
> On Wednesday 28 November 2007 11:28:48 Bernd Jendrissek wrote:
>
> > I don't think I'll get much more done for a little while as I have too
> > much other offline stuff to do (car got stolen). Please do look at
> > the code, play with it, break it, etc., tell me you love it, or that
> > it sucks. It'll just be a while before I get to do much with the
> > feedback.
>
> The stuff in your cleanups branch looks good. Should I merge it into the main
> repository?
Yes, the cleanups branch should be okay to merge. I hope that'd go
without too many conflicts, but it is maybe two weeks since I brought
it up-to-date with upstream.
> (Maybe you should make a "pu" branch like Cesar has for patches which
> are "ready" -- then I can know that I'm allowed to merge them without needing
> to ask you.)
Good idea. I'd want to have gschem able to edit slot definitions, and
have libgeda do attribute rewriting before anyone even thinks of
merging this into stable or unstable. I figured it's better to get
this out now even if it's incomplete, than to just let it rot
unnoticed.
> I don't have enough time to do a detailed review of your changes you've made
> in the main branch: they're just too extensive. I'm also still not quite
> convinced that what you've done is the Right Way, and I'm a little worried
> that once it's included we'll have to support it forever even if it turns out
> not to be the Right Way.
>
> For instance, you appear to have essentially implemented classes and signals
> in the factory/observer stuff -- I'd much rather it was implemented using
> GObject, which despite its unwieldiness is (a) well-documented, (b)
> maintained by someone else, and (c) already used extensively in gEDA anyway.
You're quite right - if we had OBJECT be a class derived from GObject,
we'd have all the Observer pattern stuff I needed, for free. I
suppose one could do without the factory too if one hooked into
signals on TOPLEVEL (which would also have to be a GObject derivate).
[Digression]
OTOH, I think the Abstract Factory pattern is a win even if it isn't
the only way to do my slotting mechanism. It could help to get all
the remaining GDK out of libgeda - things like PICTURE and COLOR.
> P.S. Your FTP server doesn't appear to anonymous access to the /pub/incoming
> directory. This is quite normal as far as FTP server configurations go: you
> need to move them to a "proper" directory for them to become accessible.
Well, it isn't *my* FTP server. As far as ther server's concerned,
I'm just some random who uploaded something civilized into
/pub/incoming instead of some pr0n!
_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev