[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gEDA: Icarus Verilog: C++ nitpicking



Joshua Boyd wrote:

> I've attached the patch below.  There was a header inclusion that I
> commented out in one file.  I wasn't sure if that header would be needed
> on other platforms, but it at least doesn't seem to be needed for OS X,
> which uses GCC (I tested my patched version of the source code on OS X
> to make sure I wasn't breaking GCC compilation of the code).  Further
> more, including stdint.h is a probablem when compiling on Solaris with
> GCC anyway.

Patch applied. For reference, I detest C-style casts so I changed
the (double)10 to 10.0L. But otherwise, I applied it as is. It still
compiles on SuSE 9.2/AMD64 so that's a good sign. It'll show up on
anonymous CVS overnight.

Thanks,

-- 
Steve Williams                "The woods are lovely, dark and deep.
steve at icarus.com           But I have promises to keep,
http://www.icarus.com         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."