Re: gEDA: o_pin_end(): connection check and drawing

[Carlos Nieves Ónega <cnieves_dot_mail-at-NOSPAMgmail_dot_com>]

Hi Werner,

El lun, 15-05-2006 a las 21:46 +0200, Werner Hoch escribió:
> Hi all,
> 
> I tried to fix a small drawing error (whichend was missing) in 
> o_pin_end() and stumbled over a failing connection check.
> 
> to reproduce the bug:
> * draw a net
> * draw a pin starting at the middle of the net
> --> no connection between the net and the pin.

I have also reproduced it.

> Guessed bug:
> The add_pin_hook can add some objects to the object_tail. 
> The following connection check fails as it checks a pin attribute, not 
> the pin itself.
> 
> Possible corrections:
> * move the add_pin_hook behind the connection checks
> or
> * save a object pointer to the pin (that's the way I've done it)

I think you are right.

> In the patch I've outcommented the drawing code too, o_pin_draw() is 
> used for that part now.
> 
> If the patch is ok, I'll clean it up and apply it.

Go ahead. Thank you for fixing it.

Carlos