Re: gEDA-dev: Patch for PCB's M4 library to fix expansion of therefdes as a macro

[Dan McMahill <dan-at-NOSPAMmcmahill_dot_net>]

Peter Clifton wrote:
> Hi,
> 
> The attached patch quotes the refdes parameter to all relevant macros (I
> think) in the PCB M4 library.
> 
> This prevents innocent refdes's like "R2" causing all mannar of pain
> when run after a macro which happens to redefine "R2".
> 
> If anyone knows of a way to force such re-defines to stay local, or to
> be backed out after a macro executes, I'd be interested to hear.
> 
> 
> There are other textual fields which aren't escaped in this way, e.g.
> Canonical name, and "value". I think "value" might be important, but
> "canonical name" should perhaps be sensible already.
> 
> I'd very much appreciate it if some keen people who use the M4 library
> might try applying this patch, perhaps even directly against their
> "$PREFIX/share/pcb/m4/" directory if brave, so that I can confirm the M4
> library still works in general usage. (My testing isn't really
> "production use" enough to catch any problems).
> 
> Worst case is you have to copy the m4 directory back from a backup, or
> re-install PCB.
> 
> Could the PCB developers take a look through the (simple and repetitive)
> patch and see if it could be applied?
> 
> Regards
> 
> Peter Clifton

Applied.  What I did is run the m4lib_to_newlib.sh script before and 
after applying your patch and verified that I got the same result.  I 
think in general this is something that should be done when touching the 
m4 libraries.

Anyway, thanks for fixing this.

-Dan






_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev