[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gEDA-dev: Default title-page behaviour
On Wed, 2006-10-18 at 21:50 +0200, Carlos Nieves Ónega wrote:
> Hi Peter,
> I fixed this bug in CVS.
>
> One comment: the new page hook calls g_add_component in g_hook.c .
> g_add_component adds the new component to the page, but the
> page->CHANGED flag is not set. I think g_add_component should set
> page->CHANGED = 1 after adding the new component. I haven't changed this
> yet.
>
> With the change described, if the user wants to close the page (with the
> titleblock) without doing anything else, gschem will ask if the user
> wants to loose the changes. I think this is ok, but I would like to hear
> people thoughts.
I would prefer a page generated with just a title-block, _not_ to ask
the user if they want to loose changes, so I think "CHANGED = 1" should
be reserved for when the user changes the page. It isn't like we're
modifying a file which already exists on disk.. at which point, it would
be useful to mark CHANGED.
Thanks for the fix,
Peter C.
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173
_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev