[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gEDA-dev: New autonumber text dialog
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Werner
> The dialog looks like this at the moment:
> http://www.h-renrew.de/download/autonumber.png
This looks great.
I would just like propose a little cosmetic change in the sort order
combobox (patch is attached): I've added some more padding, so that it
is easier to tell different icons apart. I also changed the order: I
think it's better to have text labels on the left side and icons on the
right.
If you think this adds to much size to the dialog just reduce the "xpad"
and "ypad" numbers. However with no padding it takes me a few moments to
see the separation between the "top to bottom" and "bottom to top" icons
because they look like a continuous column of horizontal lines.
By the way: I can't get the current CVS version of gschem to install
properly (main and "autonumber" branch). I'm getting the following error:
Making install in po
make[2]: Entering directory `/home/avian/src/geda/gaf/gschem/po'
/bin/sh @MKINSTALLDIRS@ /home/avian/software/share
/bin/sh: @MKINSTALLDIRS@: No such file or directory
make[2]: *** [install-data-yes] Error 127
make[2]: Leaving directory `/home/avian/src/geda/gaf/gschem/po'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/avian/src/geda/gaf/gschem'
make: *** [gschem_install] Error 2
Best regards
Tomaz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFbBh5sAlAlRhL9q8RAtZKAJ9E5gLkGccehPtQ76maulpVMzcUSACcCzja
iZrygAt4rNFh6vpH8ZFKHg8=
=1Crq
-----END PGP SIGNATURE-----
? .x_autonumber.c.swp
? combobox-width.patch
? gschem.log
Index: x_autonumber.c
===================================================================
RCS file: /home/cvspsrv/cvsroot/eda/geda/gaf/gschem/src/Attic/x_autonumber.c,v
retrieving revision 1.1.2.6
diff -u -3 -r1.1.2.6 x_autonumber.c
--- x_autonumber.c 26 Nov 2006 18:49:45 -0000 1.1.2.6
+++ x_autonumber.c 28 Nov 2006 10:49:30 -0000
@@ -894,16 +894,20 @@
}
gtk_combo_box_set_model(GTK_COMBO_BOX(sort_order), GTK_TREE_MODEL(store));
- renderer = gtk_cell_renderer_pixbuf_new();
+ renderer = gtk_cell_renderer_text_new ();
+ renderer->width = 200;
+
gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (sort_order),
renderer, FALSE);
gtk_cell_layout_set_attributes (GTK_CELL_LAYOUT (sort_order),
- renderer, "pixbuf", 0, NULL);
- renderer = gtk_cell_renderer_text_new ();
+ renderer, "text", 1, NULL);
+ renderer = gtk_cell_renderer_pixbuf_new();
+ renderer->xpad = 14;
+ renderer->ypad = 14;
gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (sort_order),
renderer, FALSE);
gtk_cell_layout_set_attributes (GTK_CELL_LAYOUT (sort_order),
- renderer, "text", 1, NULL);
+ renderer, "pixbuf", 0, NULL);
}
/* ***** STATE STRUCT HANDLING (interface between GUI and backend code) **** */
_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev