[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gEDA-dev: [PATCH 1/4] Make the interface of o_selection_addmatch the other o_selection_*()

Hi Peter,

El dom, 17-12-2006 a las 19:31 +0000, Peter TB Brett escribió:
>  /* o_selection.c */
> -GList *o_selection_add(GList *head, OBJECT *o_selected);
> +void o_selection_add(GList **head, OBJECT *o_selected);
>  void o_selection_print_all( GList *head );
>  void o_selection_select(OBJECT *object, int color);
>  void o_selection_unselect(OBJECT *object);

I'm fine with that, although personally, I'd like more a GTK like
interface (I know it was my patch, and I didn't do it):
GList *o_selection_add(GList *head, OBJECT *o_selected);
GList *o_selection_remove(GList *head, OBJECT *o_selected);
GList *o_selection_unselect_list(TOPLEVEL *w_current, GList *head);

It seems you also changed:
void o_selection_print_all( GList *head );
to:
void o_selection_print_all( GList **head );

This function doesn't modify the list, so there is no need to change
it...

Regards,

Carlos



_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev