Re: gEDA-dev: [PATCH 1/4] Make the interface of o_selection_add matchthe other o_selection_*()

[Peter TB Brett <peter-at-NOSPAMpeter-b_dot_co_dot_uk>]

On Monday 18 December 2006 18:00, Carlos Nieves Ónega wrote:

> I'm fine with that, although personally, I'd like more a GTK like
> interface (I know it was my patch, and I didn't do it):
> GList *o_selection_add(GList *head, OBJECT *o_selected);
> GList *o_selection_remove(GList *head, OBJECT *o_selected);
> GList *o_selection_unselect_list(TOPLEVEL *w_current, GList *head);

Fair enough. As I mentioned, the idea was to make them a bit more uniform, and 
it seemed like it would break more stuff if I did what you're suggesting.

Another argument in favour of the **GList syntax is that it results in 
slightly less verbose function calls. :)

Do you want me to resubmit a new patch, or shall we go ahead with this one? 
(n.b. I think patch 3/4 should go in regardless).

Peter

-- 
Fisher Society committee                    http://tinyurl.com/o39w2
CUSBC novices, match and league secretary   http://tinyurl.com/mwrc9
CU Spaceflight                              http://tinyurl.com/ognu2

v3sw6YChw7$ln3pr6$ck3ma8u7+Lw3+2m0l7Ci6e4+8t4Gb8en6g6Pa2Xs5Mr4p4
  hackerkey.com                                  peter-b.co.uk

PGP signature

_______________________________________________
geda-dev mailing list
geda-dev@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev